fix: permissions: PUT /api/permissions/roles/{id} with missing 'permissions' field silently wipes all role permissions - #277
Open
antosubash wants to merge 3 commits into
Conversation
…ssions' field silently wipes all role permissions (#269)
Deploying simple-module-python with
|
| Latest commit: |
0a8a8f0
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://55caaf69.simple-module-python.pages.dev |
| Branch Preview URL: | https://pi-issue-269-permissions-put.simple-module-python.pages.dev |
Owner
Author
|
🔧 CI repair attempt 1 pushed. I will monitor the new checks automatically. Root causeThe new regression test pushed Changes
Verification
Remaining risk: full Python test suite remains blocked by the unrelated Moto/S3 environment failure. |
Owner
Author
|
✅ CI checks passed after 1 automatic repair attempt. |
antosubash
marked this pull request as ready for review
August 28, 2026 19:50
Owner
Author
|
✅ CI checks passed for this pull request. |
antosubash
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #269
Headless Pi worker
This is a draft pull request created from an issue carrying the approval label.
It is never merged automatically and requires human review.
Agent summary
Implementation
RolePermissionsUpdate.permissionsrequired.permissionsnow returns HTTP 422 without changing assignments.{"permissions": []}remains a valid clear-all operation.Changed areas
modules/permissions/permissions/contracts/schemas.pymodules/permissions/tests/test_permissions_module.pyVerification
uv run pytest modules/permissions/tests— 29 passeduv run ty check ...— passedgit diff --check— passedVisual evidence: none required.
Risks/blockers: none.
Local visual evidence
When requested, screenshots, traces, videos, and GIFs are stored only under the worker worktree's ignored
.qa/issues/269/directory. GitHub CLI cannot attach those files; inspect them on the worker hostor attach selected evidence manually.